Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables #6

Closed
wants to merge 1 commit into from
Closed

Add variables #6

wants to merge 1 commit into from

Conversation

miguelsolorio
Copy link
Owner

@miguelsolorio miguelsolorio commented Sep 1, 2020

This PR fixes #1 and updates the style colors to use css variables.

@miguelsolorio
Copy link
Owner Author

comment one

Copy link
Owner Author

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello

@@ -1,3 +1,8 @@
:root {
--bg-dark: #282c34;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove any references to dark/light?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@@ -9,7 +14,7 @@
}

.App-header {
background-color: #282c34;
background-color: var(--link-dark);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

@@ -20,7 +25,7 @@
}

.App-link {
color: #61dafb;
color: var(--link-dark);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update styles to match system theme
1 participant