Fix parsing of .po files with no headers #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the update! Could you include a brief test that demonstrates how the pull request fixes your issue? Just something simple with a fixture similar to the one causing your issue. It'll help keep bugs like this from happening in the future. |
|
This test captures what we saw when our po2json was updated to .4.3, and the pre-PR code will fail the test with "TypeError: Cannot read property 'plural-forms' of undefined" if there is no header. Test passes after the fix. |
|
Excellent, the new release it out and should be up on npm any moment now. Thanks again for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some header-less .po files that were broken by the plurals support update.