Allow stdin to be a stream #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehaertl
reviewed
Feb 15, 2018
| @@ -172,7 +172,7 @@ public function setCommand($command) | |||
| } | |||
|
|
|||
| /** | |||
| * @param string $stdIn If set, the string will be piped to the command via standard input. | |||
| * @param string|resource $stdIn If set, the string will be piped to the command via standard input. | |||
There was a problem hiding this comment.
@Arzaroth Maybe add a little note about the resource type here? E.g. "This can also be a resource like a file handle in which case the file content will be piped into the command."
|
Looks good. Thanks! |
|
Just released 1.4.0 including your addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to allow stdin to be stream.
The goal is to emulate a left redirection (e.g.
<file wc -c)A small test is provided.