Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android-Iconics #182

Closed
dexion opened this issue Dec 28, 2015 · 6 comments
Closed

Android-Iconics #182

dexion opened this issue Dec 28, 2015 · 6 comments
Assignees
Milestone

Comments

@dexion
Copy link

dexion commented Dec 28, 2015

Android-Iconics doesn't work in AboutActivity :(

new LibsBuilder()
                .withActivityStyle(Libs.ActivityStyle.LIGHT_DARK_TOOLBAR)
                .withAboutIconShown(true)
                .withAboutVersionShown(true)
                .withAboutDescription("{faw-android} This is a small sample.<br /><b>You can style this with html markup :D</b>")
                .start(context);

{faw-android} shown like text, not icon. In other TextViews this alias work perfectly

@mikepenz
Copy link
Owner

@dexion good idea. I'll probably add the Iconics-core as dependency to the AboutLibraries, so this is also possible.

@mikepenz mikepenz self-assigned this Dec 28, 2015
@Rainer-Lang
Copy link
Contributor

Good idea

@mikepenz mikepenz modified the milestones: v5.3.0, v5.3.5 Dec 28, 2015
@dexion
Copy link
Author

dexion commented Dec 29, 2015

Thanks for that! But now html markup is broken: at least <b> tag doesn't work (shown like regular text, not bold)

@mikepenz
Copy link
Owner

@dexion ok that's a problem with Android-Iconics if i apply the icon fonts, i will create new spans on the text. As the Html.fromText() already created the spans, i will overwrite them. That will be a more complex task. will look into it.

mikepenz added a commit to mikepenz/Android-Iconics that referenced this issue Dec 29, 2015
* keep previous defined spannables if iconics is applied on a view
* changed from Spannable to Spanned to even allow more use cases
FIX mikepenz/AboutLibraries#182
@mikepenz mikepenz modified the milestones: v5.3.6, v5.3.5 Dec 29, 2015
@mikepenz
Copy link
Owner

@dexion ok this issue is now also fixed in v5.3.6

@dexion
Copy link
Author

dexion commented Dec 30, 2015

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants