add unit handling and connection checking #29
Conversation
|
What do you make of the error that this is getting on Linux? |
|
Given that both appveyor and travis have an error in the git clone step, maybe github was down for a short time and they couldn't fetch? Certainly looks like some sort of timeout problem that is not related to your code at all. I'll look at the PR once I'm done with my lecture! |
|
|
||
| # Check the units, if provided | ||
| @assert unitcheck(getmetainfo(m, target_component).parameters[target_name].unit, | ||
| getmetainfo(m, source_component).variables[source_name].unit) "Units of $source_component.$source_name do not match $target_component.$target_name." |
There was a problem hiding this comment.
I think we should not use @assert here, there is some discussion that those statements might turn into no-ops for higher optimization levels in julia (JuliaLang/julia#10614). Probably safest to just use an if and then throw construction here. I would just throw an ErrorException if things don't match.
|
Alright, I've added some smallish comments. Very nice, thanks a lot! |
|
Like the commit message says, I tried to address all of these pieces in light of our conversation. In particular:
Plus the other things you asked for:
|
|
Perfect, thanks a lot! |
This is the component-to-component part of the unit checking system. You add new units like this:
waterdemand = Parameter(index=[regions, time], units="1000 m^3")and when you call
connectparameterwith two components, it checks that the units match, allowing a specialanyunit that matches anything, but otherwise requiring that the units are the same or both missing. I have all my calls like this through lines like:allocation[:waterdemand] = waterdemand[:totaldemand]This does not (1) handle any unit checking anywhere except for through
connectparameter(and not the version ofconnectparameterthat takes an already-added parameter as an argument, (2) have any logic for theUnitedObjectthat I mentioned before, nor (3) apply the unit logic to equations.