Skip to content

upgrade to PHP 8.3 #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 11, 2024
Merged

upgrade to PHP 8.3 #588

merged 6 commits into from
Dec 11, 2024

Conversation

mimmi20
Copy link
Owner

@mimmi20 mimmi20 commented Dec 11, 2024

No description provided.

@mimmi20 mimmi20 added dependencies Pull requests that update a dependency file maintenance Maintenance bc break BC Break labels Dec 11, 2024
@mimmi20 mimmi20 self-assigned this Dec 11, 2024
Copy link
Contributor

github-actions bot commented Dec 11, 2024

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

composer.json

PackageVersionLicenseIssue Type
php~> 8.3.0 || ~> 8.4.0 || ~> 8.5.0NullUnknown License

OpenSSF Scorecard

Scorecard details
PackageVersionScoreDetails
actions/mimmi20/ci/.github/workflows/analytics.yml 8.3 UnknownUnknown
actions/mimmi20/ci/.github/workflows/validate.yml 8.3 UnknownUnknown
composer/infection/infection >= 0.29.8, < 0.30.0 🟢 5.7
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow⚠️ -1no workflows found
Token-Permissions⚠️ -1No tokens found
Code-Review🟢 7Found 23/30 approved changesets -- score normalized to 7
Maintained🟢 54 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 5
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ -1no dependencies found
Fuzzing⚠️ 0project is not fuzzed
Security-Policy⚠️ 0security policy file not detected
Vulnerabilities🟢 100 existing vulnerabilities detected
License🟢 10license file detected
Signed-Releases🟢 85 out of the last 5 releases have a total of 5 signed artifacts.
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
composer/laminas/laminas-servicemanager >= 3.22.1, < 4.0.0 UnknownUnknown
composer/mimmi20/coding-standard >= 6.0.1, < 7.0.0 UnknownUnknown
composer/nikic/php-parser >= 5.3.1, < 6.0.0 🟢 5
Details
CheckScoreReason
Maintained🟢 1017 commit(s) and 15 issue activity found in the last 90 days -- score normalized to 10
Token-Permissions⚠️ -1No tokens found
Packaging⚠️ -1packaging workflow not detected
Code-Review⚠️ 2Found 6/29 approved changesets -- score normalized to 2
Dangerous-Workflow⚠️ -1no workflows found
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Pinned-Dependencies⚠️ -1no dependencies found
Binary-Artifacts🟢 10no binaries found in the repo
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Vulnerabilities🟢 100 existing vulnerabilities detected
Signed-Releases⚠️ -1no releases found
Branch-Protection🟢 3branch protection is not maximal on development and all release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
composer/php ~> 8.3.0 || ~> 8.4.0 || ~> 8.5.0 🟢 5.4
Details
CheckScoreReason
Code-Review⚠️ 1Found 4/30 approved changesets -- score normalized to 1
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Maintained🟢 1030 commit(s) and 21 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Security-Policy🟢 10security policy file detected
Token-Permissions🟢 9detected GitHub workflow tokens with excessive permissions
Dangerous-Workflow⚠️ 0dangerous workflow patterns detected
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection🟢 3branch protection is not maximal on development and all release branches
Vulnerabilities🟢 100 existing vulnerabilities detected
Fuzzing🟢 10project is fuzzed
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts🟢 8binaries present in source code
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
composer/phpunit/phpunit >= 11.4.4, < 12.0.0 🟢 5.2
Details
CheckScoreReason
Dangerous-Workflow⚠️ -1no workflows found
Token-Permissions⚠️ -1No tokens found
Code-Review⚠️ 0Found 1/30 approved changesets -- score normalized to 0
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 1030 commit(s) and 19 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ -1no dependencies found
Vulnerabilities🟢 100 existing vulnerabilities detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
composer/symfony/mailer >= 7.2.0, < 8.0.0 🟢 5.2
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow⚠️ -1no workflows found
Code-Review⚠️ 0Found 0/30 approved changesets -- score normalized to 0
Maintained🟢 1027 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
Token-Permissions⚠️ -1No tokens found
SAST⚠️ 0no SAST tool detected
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ -1no dependencies found
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Vulnerabilities🟢 100 existing vulnerabilities detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Security-Policy🟢 10security policy file detected
composer/symfony/mime >= 7.2.0, < 8.0.0 🟢 5.2
Details
CheckScoreReason
Dangerous-Workflow⚠️ -1no workflows found
Token-Permissions⚠️ -1No tokens found
Code-Review⚠️ 0Found 0/30 approved changesets -- score normalized to 0
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 1020 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
SAST⚠️ 0no SAST tool detected
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ -1no dependencies found
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Vulnerabilities🟢 100 existing vulnerabilities detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Security-Policy🟢 10security policy file detected
composer/symfony/process >= 7.2.0, < 8.0.0 🟢 5.2
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Token-Permissions⚠️ -1No tokens found
Dangerous-Workflow⚠️ -1no workflows found
SAST⚠️ 0no SAST tool detected
Maintained🟢 1030 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
Pinned-Dependencies⚠️ -1no dependencies found
Code-Review⚠️ 0Found 0/30 approved changesets -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
Vulnerabilities🟢 100 existing vulnerabilities detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Security-Policy🟢 10security policy file detected

Scanned Files

  • .github/workflows/continuous-integration.yml
  • composer.json

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.03%. Comparing base (394ecf1) to head (697b021).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/Handler/RollbarHandlerFactory.php 0.00% 1 Missing ⚠️
src/Handler/TeamsLogHandlerFactory.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #588   +/-   ##
=========================================
  Coverage     95.03%   95.03%           
  Complexity      778      778           
=========================================
  Files           104      104           
  Lines          2842     2842           
=========================================
  Hits           2701     2701           
  Misses          141      141           
Flag Coverage Δ
php-8.1 ?
php-8.3 95.03% <97.91%> (?)
php-amqplib 89.97% <97.91%> (ø)
phpunit 95.03% <97.91%> (ø)
ubuntu-24.04 95.03% <97.91%> (ø)
with amqp 88.42% <97.91%> (ø)
with curl 91.09% <97.91%> (ø)
with mongodb 88.42% <97.91%> (ø)
with-sockets 90.28% <97.91%> (ø)
without-extensions 87.96% <97.91%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/AddFormatterTrait.php 100.00% <ø> (ø)
src/AddProcessorTrait.php 100.00% <ø> (ø)
src/Client/ElasticsearchV7Factory.php 100.00% <100.00%> (ø)
src/Client/ElasticsearchV8Factory.php 100.00% <100.00%> (ø)
src/ClientPluginManagerFactory.php 100.00% <100.00%> (ø)
src/ConfigProvider.php 100.00% <ø> (ø)
src/CreateFormatterTrait.php 100.00% <ø> (ø)
src/CreateProcessorTrait.php 100.00% <ø> (ø)
src/Formatter/ChromePHPFormatterFactory.php 100.00% <100.00%> (ø)
src/Formatter/ElasticaFormatterFactory.php 100.00% <100.00%> (ø)
... and 94 more

Copy link

codeclimate bot commented Dec 11, 2024

Code Climate has analyzed commit 697b021 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 95.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.6% (-2.7% change).

View more on Code Climate.

@mimmi20 mimmi20 merged commit a6ff91a into master Dec 11, 2024
302 of 303 checks passed
@mimmi20 mimmi20 deleted the updates branch December 11, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc break BC Break dependencies Pull requests that update a dependency file maintenance Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant