Require symfony/process as dev dependency #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=========================================
Coverage 83.54% 83.54%
Complexity 191 191
=========================================
Files 1 1
Lines 468 468
=========================================
Hits 391 391
Misses 77 77 ☔ View full report in Codecov by Sentry. |
|
Reason? |
|
@oleg-andreyev |
aik099
reviewed
Mar 18, 2024
Comment on lines
+26
to
+27
| "symfony/error-handler": "^5.4 || ^6.0 || ^7.0", | ||
| "symfony/process": "^5.4 || ^6.0 || ^7.0", |
There was a problem hiding this comment.
If this driver was already released, then I would suggest moving the || ^7.0 part to a different PR for adding Symfony 7 support.
Except for that, everything looks good.
There was a problem hiding this comment.
Driver is WIP , so it's okay to merge as is
oleg-andreyev
approved these changes
Mar 20, 2024
stof
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.