Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't iterate windows, when already at correct window #24

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Mar 21, 2024

I've noticed, that when trying to resize/maximize the current window several calls are made to the Selenium server to verify if we're at the right window. IMO they're unnecessary because we're surely at the correct window already.

P.S.
There is no test to verify, that resizing/maximizing non-current window works.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (8a540d9) to head (97d00f8).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #24      +/-   ##
============================================
+ Coverage     83.54%   83.65%   +0.10%     
- Complexity      191      192       +1     
============================================
  Files             1        1              
  Lines           468      471       +3     
============================================
+ Hits            391      394       +3     
  Misses           77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uuf6429 uuf6429 self-requested a review March 21, 2024 21:32
Copy link
Member

@uuf6429 uuf6429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right.

@uuf6429 uuf6429 merged commit 71c242b into minkphp:main Mar 22, 2024
29 checks passed
@aik099 aik099 deleted the with-window-opimization branch April 8, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants