Zig Fiat-Crypto-generated code is now continuously tested #959
Conversation
jedisct1
changed the title
|
That's great to hear! I'd like to reserve the heavy checkmark for tests that will be applied to pull requests before they are merged, i.e., backends where we expect that introducing, e.g., a transcription error changing Is there a way to add a test to our CI that runs our code against the Zig crypto test-suite? |
JasonGross
changed the title
|
Oh, absolutely, I can add that! |
The first bits of fiat-generated code have landed into the Zig standard library. The code is now continuously tested on all supported platforms.
|
Meanwhile, the check mark has been replaced by the white one. |
|
Great, thanks! Could I trouble you too provide links to Zig's CI (if it's public) and to the part of the standard library that includes fiat-crypto (I couldn't find it with a brief Google search) |
|
The generated code is now directly tested in fiat-crypto's CI: https://github.com/mit-plv/fiat-crypto/blob/master/fiat-zig/src/main.zig in addition to the inversion code, that is also part of what is run by CI. These tests are run in debug mode, which checks for arithmetic overflow. And will also check for unexpected truncation with help of #939 |
The first bits of Fiat-generated code have landed into the Zig standard library.
The code is now continuously tested on all supported platforms.