[stdlib] Add append() and extend() unsafe_no_checks parameter
#4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: martinvuyk <[email protected]>
|
If we do want this change, I'd like to keep |
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
JoeLoser
reviewed
Mar 18, 2025
| if self._len >= self.capacity: | ||
| self._realloc(self.capacity * 2 | Int(self.capacity == 0)) | ||
| self._unsafe_next_uninit_ptr().init_pointee_move(value^) | ||
| self._len += 1 | ||
|
|
||
| fn append[*, unsafe_no_checks: Bool](mut self, owned value: T): |
There was a problem hiding this comment.
@ConnorGray WDYT about this? We've talked about this in the past.
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
modularbot
pushed a commit
that referenced
this pull request
Mar 22, 2025
…logic (#58174) [External] [stdlib] Remove `List.pop()`'s buffer shrinking (realloc) logic Remove `List.pop()`'s buffer shrinking (realloc) logic. This is a split-off from #4151. This change is useful to avoid redundant (and surprising) buffer reallocations. Co-authored-by: martinvuyk <[email protected]> Closes #4156 MODULAR_ORIG_COMMIT_REV_ID: 178d81969dc2bce2bc7fb94a727feb0f5d56e3bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
append()andextend()unsafe_no_checksparameter.This gives the best performance without having to use pointers directly when memory was reserved previously.
Merge after #4156 and #4158