Works around phenogrid's biolink backend sniffing #476
Conversation
…grid's constructor. PhenoGrid.vue sets it to true so that the component always works against the biolink API.
|
✔️ Deploy Preview for monarch-ui ready! 🔨 Explore the source changes: 971348a 🔍 Inspect the deploy log: https://app.netlify.com/sites/monarch-ui/deploys/61bbd9fe8b91540007b9ff9b 😎 Browse the preview: https://deploy-preview-476--monarch-ui.netlify.app/ |
There was a problem hiding this comment.
Look good.
But it looks like you published the new phenogrid to npm but haven't pushed it to the repo yet?
https://www.npmjs.com/package/phenogrid (1.5.3 published 1 hour ago)
https://github.com/monarch-initiative/phenogrid (last commit on master aug 12, no recent branches)
I'd just like to take a look at the changes to phenogrid somehow.
|
Right, sorry about that; I'd updated my fork, but not the parent repo. It should be updated now. Also, I don't know why this didn't show up when I was testing locally, but there's something going on with phenogrid/jquery-ui that's throwing an error and causing the component not to render correctly. I've changed the PR to a draft until I sort it out; I'll switch it back once it's ready. |
|
Turns out that by chance I had an older version of jquery-ui (v1.12.1) installed in my phenogrid project folder, but apparently later versions (e.g. 1.13.0) are for some reason incompatible with the component. Pinning the version to exactly 1.12.1 seems to fix it. |
The phenogrid component checks if the backend API matches a fixed set of hostnames to determine if it's a biolink API or not. Unfortunately, this breaks the component while we're using a non-standard backend API URL.
This PR updates phenogrid to 1.5.3, which adds the
forceBiolinkflag to phenogrid's constructor.PhenoGrid.vuesets it to true, so that the component always works against the biolink API regardless of the backend API URL.