This repository was archived by the owner on Dec 20, 2023. It is now read-only.
Add ability to control mongo download #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies, but could I have you redo this PR so that the linting and actual changes are in separate commits? |
LoneRifle
suggested changes
Nov 26, 2018
src/mongod-helper.ts
Outdated
| @@ -92,4 +104,8 @@ export class MongodHelper { | |||
| return /shutting down with code/i; | |||
| } | |||
|
|
|||
| stop(): void { | |||
| this.mongoBin.childProcess.kill('SIGINT'); | |||
| } | |||
There was a problem hiding this comment.
This will not be needed as this has been implemented in #49
added 2 commits
December 1, 2018 11:40
* Create `IMongoDBDownloadOpts`, options passed on to MongoDBDownload * Make relevant changes to MongoDBPrebuilt ctor to accept the options
LoneRifle
approved these changes
Dec 1, 2018
|
Sorry, I didn't see the notifications on these messages and I left you with a bit of extra work. Is it all sorted now? |
|
Yes it is - published as 6.4.0. I had to force-push into your branch as part of the work done, sorry about that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to be able to download a specific version of mongo to run our tests. So we added the ability to pass in options that go to the mongodb-download package. We've tested that this runs cleanly in the default mode as well as with the options.
We also added some scripts for linting and building in package.json. We left in the fix option on the linting which has added a lot of spacing and formatting changes. Apologies for that.
Fixes #50
Fixes #42