This repository was archived by the owner on Dec 20, 2023. It is now read-only.
Passing download parameters to bin commands through ENV variables #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoneRifle
suggested changes
Jan 23, 2019
There was a problem hiding this comment.
A couple of points:
- I don't wish to have
.editorconfigin this PR, since not everybody uses this. Can you remove this please? - I will usually build the files myself, so please remove everything in
built/ - I like that you have reused a mongodb-download class, but you are conflating this with the actual PR itself. At the very least, I would like two separate commits
|
Sure, will do. |
|
Apologies, one more comment - env vars are usually |
|
@LoneRifle please review |
LoneRifle
approved these changes
Jan 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal of the pr is to set MongoDB version and download folder instead of latest version of MongoDB and home directory to download to use through bin commands.
Environment variables to set mongodb download parameters:
MONGODB_VERSIONMONGODB_DOWNLOADDIRMONGODB_ARCHMONGODB_PLATFORMExample
export mongodb_downloadDir='./' mongodb_version=3.4.10 && mongod --port 27018 --dbpath ./.mongodb/data --logpath /dev/stdout