-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-45968-redirecting-old-require-modules #105
Conversation
✅ Deploy Preview for docs-mongodb-vscode ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor preference below! but overall looks good 👍
@@ -0,0 +1,4 @@ | |||
define: base https://www.mongodb.com/docs/mongodb-vscode | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor nit] following a similar pattern as other docs, can we define prefix and use it in the base
definition as well as the first rule?
ie.
define: prefix docs/mongodb-vscode
define: base https://www.mongodb.com/${prefix}
raw: ${prefix}/require-modules -> ${base}/require-playgrounds/require-modules/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thanks for your feedback!
DESCRIPTION
Output for
mut-redirects config/redirects
:Redirect 301 /docs/mongodb-vscode/require-modules https://www.mongodb.com/docs/mongodb-vscode/require-playgrounds/require-modules/
JIRA
https://jira.mongodb.org/browse/DOCSP-45968
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?