Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-45968-redirecting-old-require-modules #105

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Dec 12, 2024

DESCRIPTION

Output for mut-redirects config/redirects:

Redirect 301 /docs/mongodb-vscode/require-modules https://www.mongodb.com/docs/mongodb-vscode/require-playgrounds/require-modules/

JIRA

https://jira.mongodb.org/browse/DOCSP-45968

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for docs-mongodb-vscode ready!

Name Link
🔨 Latest commit 9e26c3f
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongodb-vscode/deploys/675c71687064570008eacbab
😎 Deploy Preview https://deploy-preview-105--docs-mongodb-vscode.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 32 (🟢 up 4 from production)
Accessibility: 91 (no change from production)
Best Practices: 75 (no change from production)
SEO: 75 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ltran-mdb2 ltran-mdb2 requested a review from seungpark December 12, 2024 19:28
Copy link

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor preference below! but overall looks good 👍

@@ -0,0 +1,4 @@
define: base https://www.mongodb.com/docs/mongodb-vscode

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor nit] following a similar pattern as other docs, can we define prefix and use it in the base definition as well as the first rule?

ie.

define: prefix docs/mongodb-vscode
define: base https://www.mongodb.com/${prefix}

raw: ${prefix}/require-modules -> ${base}/require-playgrounds/require-modules/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks for your feedback!

@ltran-mdb2 ltran-mdb2 merged commit 1b5d17d into mongodb:master Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants