DOCS-14433 config.transactions read concern disallowed #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-allen-mongo
requested changes
Sep 1, 2021
| @@ -0,0 +1,10 @@ | |||
| Starting in MongoDB 5.0, non-transaction reads are not allowed on | |||
| :ref:`config.transactions<config.transactions>` | |||
There was a problem hiding this comment.
Two things:
- Please use
:data:`config.transactions`
for this link instead of a ref link.
- I think we should say:
not allowed on the :data:`config.transactions` collection with the following...
Comment on lines
5
to
10
| - :ref:`read concern "snapshot"<readconcern-snapshot>` | ||
| - :ref:`read concern "majority"<readconcern-majority>` and the | ||
| :ref:`afterClusterTime<afterClusterTime>` option is set | ||
| - When using a `MongoDB Driver <https://docs.mongodb.com/drivers/?tck=docs_server>`_ | ||
| and :ref:`read concern "majority"<readconcern-majority>` | ||
| within a :ref:`causally consistent session<sessions>` |
There was a problem hiding this comment.
Please update these to use the :readconcern: links instead of refs
| @@ -10,6 +10,8 @@ Read Concern ``"majority"`` | |||
| :depth: 1 | |||
| :class: singlecol | |||
|
|
|||
| .. _readconcern-majority: | |||
There was a problem hiding this comment.
You don't need to add these refs. .. readconcern:: "majority" you can already point to this place in the docs by using:
:readconcern:`"majority"`
| - :ref:`read concern "snapshot"<readconcern-snapshot>` | ||
| - :ref:`read concern "majority"<readconcern-majority>` and the | ||
| :ref:`afterClusterTime<afterClusterTime>` option is set | ||
| - When using a `MongoDB Driver <https://docs.mongodb.com/drivers/?tck=docs_server>`_ |
There was a problem hiding this comment.
You can do:
:driver:`MongoDB Driver </>`
This is defined in the snooty rst spec: https://github.com/mongodb/snooty-parser/blob/master/snooty/rstspec.toml
| @@ -0,0 +1,10 @@ | |||
| Starting in MongoDB 5.0, non-transaction reads are not allowed on | |||
| :ref:`config.transactions<config.transactions>` | |||
| with the following read concerns and considerations: | |||
There was a problem hiding this comment.
[minor] "options" may be better than "considerations" here
ianf-mongodb
force-pushed
the
DOCS-14433-Non-transactional-reads-on-config-transaction-collection
branch
3 times, most recently
from
00e54e4 to
be8a379
Compare
source/reference/config-database.txt
Outdated
| @@ -524,6 +526,8 @@ instance. | |||
| the ``system.sessions`` collection into at least 1024 chunks and | |||
| distributes the chunks uniformly across shards in the cluster. | |||
|
|
|||
| .. _config.transactions: | |||
There was a problem hiding this comment.
I think we can remove this as well.
There was a problem hiding this comment.
Removed on latest commit.
ianf-mongodb
force-pushed
the
DOCS-14433-Non-transactional-reads-on-config-transaction-collection
branch
from
be8a379 to
1bb91a0
Compare
jeff-allen-mongo
approved these changes
Sep 2, 2021
mongo-cr-bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
* DOCSP-35317 5.0.24 Release Notes * * * fix affected versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.