Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-13871 Add REPL output to serverStatus command #5873

Conversation

ianf-mongodb
Copy link
Contributor

No description provided.

Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions before merge.

@@ -895,6 +895,13 @@ Security Counter
which reports the number of times a :dbcommand:`hello` request
includes a valid :data:`hello.saslSupportedMechs` field.

Repl
- :serverstatus:`repl` now includes a
:ref:`primaryOnlyServices<server-status-repl>` document which
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • Should this go into the "Replication Metrics" section above this one, rather than creating a new "Repl" section?
  • Should we link directly to the "primaryOnlyServices" document? As in:
:serverstatus:`~repl.primaryOnlyServices`

The tilde at the beginning trims everything before the field name, so it should render as "primaryOnlyServices" rather than "repl.primaryOnlyServices".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "document 'that' contains", not 'which'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the link and the "which" -> "that", as for the repl output I feel it is more appropriate to leave it as is I feel like this would have come out in TR if it were not the case. I attached a copy of serverStatus output to the ticket where metrics shows under a different document hierarchy.

@ianf-mongodb ianf-mongodb force-pushed the DOCS-13871-add-repl-output-to-serverStatus-section branch from 1723f92 to e0788bb Compare September 24, 2021 19:23
@jeff-allen-mongo jeff-allen-mongo merged commit 15d1e4b into mongodb:master Sep 24, 2021
mongo-cr-bot pushed a commit that referenced this pull request Jan 18, 2024
…Notes (#5604) (#5873)

* DOCSP-35017 Add vm.force_cgroup_v2_swappiness recommendation to Prod Notes

* ES suggestions

* note placement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants