Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-13479 Add note for out and merge behavior on RS #6064

Conversation

ianf-mongodb
Copy link
Contributor

FYI this was marked as a 5.1 but was actually implemented in 4.4, drivers implementation may lag hence the note "Check your driver documentation to see when your driver added support for :pipeline:$merge read operations running on
secondary nodes".

Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ianf-mongodb , thanks for making these changes. I have a few quick notes on formatting and then I can merge this in. Thanks

@ianf-mongodb ianf-mongodb force-pushed the DOCS-13479-out-merge-on-secondaries branch from 96d2d30 to 257a0b2 Compare October 29, 2021 15:46
Copy link
Contributor Author

@ianf-mongodb ianf-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the monospace on the referenced elements.

Just curious if I accept the edit here, do I have to wait for the merge before I can rebase the changes into my local? I opted to make the edits locally so I can cherry-pick immediately.

@jeff-allen-mongo
Copy link
Collaborator

@ianf-mongodb , if you accept edits via GitHub they go onto your origin fork's branch. You don't need to wait for merge, but you'll need to rebase the changes from your origin. As in, run:

git pull --rebase origin DOCS-13479-out-merge-on-secondaries

Then you should be good to go.

@jeff-allen-mongo jeff-allen-mongo merged commit 34fcb8f into mongodb:master Oct 29, 2021
mongo-cr-bot pushed a commit that referenced this pull request Jan 30, 2024
…tion attribute (#5833) (#6064)

* DOCSP-16072 doc for new Search Sequential Pagination attribute (#5833)

* DOCSP-16072 doc for new Search Sequential Pagination attribute

* Update source/includes/fact-meta-syntax.rst

Co-authored-by: Jeff Allen <[email protected]>

* DOCSP-16072 fix for broken link

---------

Co-authored-by: Jeff Allen <[email protected]>

* DOCSP-36041 add minor version

* DOCSP-36041 updates for staging issue

* Apply suggestions from code review

Co-authored-by: Jeff Allen <[email protected]>

---------

Co-authored-by: Jeff Allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants