CSHARP-4911: Implement single entry point for all driver's extensions. #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
requested review from
adelinowona and
BorisDog
and removed request for
a team and
adelinowona
BorisDog
reviewed
Sep 27, 2024
| /// <summary> | ||
| /// Auth Registry Extensions. | ||
| /// </summary> | ||
| public static class RegistrationHelpers |
There was a problem hiding this comment.
IExtensionManagerExtensions ?
| /// Registers AWS Kms Provider. | ||
| /// </summary> | ||
| /// <param name="extensionManager">Extensions Manager.</param> | ||
| public static IExtensionManager RegisterAWSKmsProvider(this IExtensionManager extensionManager) |
There was a problem hiding this comment.
General naming question, do we want to register or add ?
There was a problem hiding this comment.
Done + expose single method only as discussed
sanych-sun
changed the title
BorisDog
approved these changes
Sep 27, 2024
sanych-sun
force-pushed
the
extensions-manager
branch
from
77e8fdc to
cb198ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to CSHARP-4911: Refactor AWS auth library to a separate package