CSHARP-5506: Support Dictionary get_Item for keys that aren't strings but are serialized as strings. #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but are serialized as strings.
sanych-sun
reviewed
Mar 13, 2025
| keyAst = keyTranslation.Ast; | ||
| } | ||
|
|
||
| var ast = AstExpression.GetField(dictionaryTranslation.Ast, keyAst); // TODO: verify that dictionary is using Document representation |
There was a problem hiding this comment.
I think this TODO could be removed, as it was checked in line 119
There was a problem hiding this comment.
Also refactored error checking quite a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.