Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSHARP-5515: Implement $convert binData <-> int, long #1637

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Mar 18, 2025

No description provided.

@papafe papafe requested a review from rstam March 18, 2025 10:12
@@ -152,5 +152,221 @@ public static bool IsNullOrMissing<TField>(TField field)
{
throw CustomLinqExtensionMethodHelper.CreateNotSupportedException();
}

/// <summary>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add the docs at the end

@papafe
Copy link
Contributor Author

papafe commented Mar 18, 2025

@rstam This is a draft, as there are a couple of things missing, but I wanted to get some initial feedback.
Regarding the ConvertToBinDataFromType(Type value, BsonBinarySubType subtype, string format, BsonBinaryData onError, BsonBinaryData onNull) methods, I'm unsure if we should allow onError and onNull to be nulls.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant