Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix runCommand bench hello size #4316

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Nov 6, 2024

Description

What is changing?

  • Fix the inaccurate command document size
Is there new documentation needed for these changes?

No

What is the motivation for this change?

When we changed to hello from the legacy hello the size wasn't updated. We left it as is to preserve our performance history but with our recent reset, we should update this now

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the chore-fix-runCommand-size branch from e1275db to 43fa4b7 Compare November 7, 2024 16:02
@nbbeeken nbbeeken marked this pull request as ready for review November 7, 2024 16:03
@dariakp dariakp added the Blocked Blocked on other work label Nov 7, 2024
@dariakp
Copy link
Contributor

dariakp commented Nov 7, 2024

Wait to merge until we are done with our current perf analysis task for CSOT

@dariakp dariakp merged commit 4842cd8 into main Nov 27, 2024
25 of 29 checks passed
@dariakp dariakp deleted the chore-fix-runCommand-size branch November 27, 2024 19:06
@dariakp dariakp removed the Blocked Blocked on other work label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants