Update frontier to address pov underestimations #3227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarekkMA
added
B5-clientnoteworthy
RomarQ
reviewed
Mar 25, 2025
WASM runtime size check:Compared to target branchMoonbase runtime: 2424 KB (+4 KB) 🚨 Moonbeam runtime: 2408 KB (+4 KB) 🚨 Moonriver runtime: 2396 KB (no changes) ✅ Compared to latest release (runtime-3600)Moonbase runtime: 2424 KB (+468 KB compared to latest release) 🚨 Moonbeam runtime: 2408 KB (+464 KB compared to latest release) 🚨 Moonriver runtime: 2396 KB (+456 KB compared to latest release) |
RomarQ
reviewed
Mar 25, 2025
Coverage Report@@ Coverage Diff @@
## master tarekkma/update-frontier-and-fix-pov +/- ##
=======================================================================
Coverage 74.20% 74.20% 0.00%
Files 383 383
+ Lines 97215 97217 +2
=======================================================================
+ Hits 72133 72134 +1
+ Misses 25082 25083 +1
|
RomarQ
requested changes
Mar 25, 2025
# Conflicts: # Cargo.lock # test/suites/dev/moonbase/test-fees/test-length-fees2.ts # test/suites/dev/moonbase/test-precompile/test-precompile-assets-erc20d.ts # test/suites/dev/moonbase/test-precompile/test-precompile-proxy.ts # test/suites/dev/moonbase/test-randomness/test-randomness-babe-lottery2.ts # test/suites/dev/moonbase/test-randomness/test-randomness-babe-lottery3.ts # test/suites/dev/moonbase/test-randomness/test-randomness-vrf-lottery4.ts # test/suites/dev/moonbase/test-randomness/test-randomness-vrf-lottery5.ts # test/suites/dev/moonbase/test-storage-growth/test-precompile-storage-growth.ts
This reverts commit c364169.
This reverts commit 9139881.
…ntier-and-fix-pov
TarekkMA
added
breaking
RomarQ
reviewed
Apr 1, 2025
RomarQ
reviewed
Apr 1, 2025
test/suites/dev/moonbase/test-parameters/test-parameters-runtime-FeesTreasuryProportion.ts
Show resolved
Hide resolved
RomarQ
reviewed
Apr 1, 2025
There was a problem hiding this comment.
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
test/suites/dev/moonbase/test-xcm-v3/test-mock-hrmp-transact-ethereum-12.ts:89
- Verify that the updated multiplier (26000n) correctly reflects the intended gas cost increase and update the inline comment to clarify the rationale behind this change.
const targetXcmWeight = GAS_LIMIT * 26000n + STORAGE_READ_COST + 4_250_000_000n;
test/suites/dev/moonbase/test-storage-growth/test-precompile-storage-growth.ts:40
- Confirm that the updated inline snapshot value (51888n) for estimated gas is consistent with the new gas cost parameters and that it accurately tests the updated logic.
expect(estimatedGas).toMatchInlineSnapshot(`51888n`);
test/suites/dev/moonbase/test-parameters/test-parameters-runtime-FeesTreasuryProportion.ts:179
- [nitpick] The revised fee calculation logic now uses a min function and computes tip fees differently; consider adding an inline comment to explain the rationale and handling of edge cases, ensuring the behavior aligns with expected fee structures.
const max_fee_per_gas = GENESIS_BASE_FEE;
test/helpers/block.ts:214
- [nitpick] The conditional logic adjusting baseFeesPaid and tipAsFeesPaid may not clearly cover all edge cases; consider refactoring or adding documentation to enhance clarity and ensure correctness.
if (actualPaidFees < baseFeesPaid + tipAsFeesPaid) {
RomarQ
previously approved these changes
Apr 9, 2025
test/suites/dev/moonbase/test-xcm-v3/test-mock-hrmp-transact-ethereum-12.ts
Outdated
Show resolved
Hide resolved
RomarQ
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Update frontier to address pov underestimations
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?
gas cost has been increased.