SyntaxError: invalid regexp group

[michelcve]

When I install your addon, I get the following error in the console: "SyntaxError: invalid regexp group"

Same thing happens with our own demo: http://bestof.morganatwork.com/storybook-addon-xd-designs/

[emiliemarchand]

This is due to lookbehind assertions in the following regexes. It is an ES2018 feature, which is not yet supported by Firefox.

// lib/register/components/XD.js
const parseReviewUrl = (url) => url && url.match(/https:\/\/xd.adobe.com\/view\/(?<reviewId>[0-9a-zA-Z-]{22,128})/);
const parseSpecUrl = (url) => url && url.match(/https:\/\/xd.adobe.com\/spec\/(?<specId>[0-9a-zA-Z-]{22,128})\/screen\/(?<screenId>[0-9a-zA-Z-]{22,128})\/(?<artboard>[^\/]*)\/?$/);

[morgs32]

Where's the lookbehind? Might it be that the browser just doesn't support named capture groups? I'll remove them anyhow. @michelcve sorry for not getting to this long ago.

[emiliemarchand]

@morgs32 My bad, I saw the (?< pattern and assumed it was a lookbehind but you're right it's a named capture group. It's also an ES2018 feature so it causes the same error.

[morgs32]

Fixed in 5.4.0