Skip to content

draft: add ability to select multiple packages #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

draft: add ability to select multiple packages #47

wants to merge 2 commits into from

Conversation

darukutsu
Copy link
Contributor

@darukutsu darukutsu commented Mar 9, 2025 •
edited
Loading

fixes #26

  • for now there is problem after installing/uninstalling not clearing visual marks due to we list cached search... will fix later
  • needs testing
  • also can you provide me cli examples for all the TODOs marks in code, so I can implement them somehow, i have no idea what it looks like, maybe document those also in manpage as well
  • code itself is trash, I don't like how it looks feel free to change/optimize it
  • add ability to mark for reinstallation

Quick video how it works for now:

pacseek.mp4

darukutsu added 2 commits March 9, 2025 12:44
@darukutsu
draft: add ability to select multiple packages
fe80fdf 
fixes moson-mo#26
@darukutsu
fixing code
9de7057 
fix issue with cache, now everything works flawlessly...
fix issue with performance
add descriptive comments and make code more readable
@darukutsu
Copy link
Contributor Author

darukutsu commented Mar 22, 2025 •
edited
Loading

now we cooking :D... Ok so fixed my bad code now marks will correctly appear disappear in multiple pages cuz we're flushing cache. I made it so even if we abort halfway through installation, apps which were marked, but not installed will have preserved marks, so we can modify install list.

I still need examples for those TODOs in commands.go I mean {giturl},{optdepends}... so I can finally implement those and finalize this PR.

Hmm... my video of how it works wasn't uploaded and for some reason I can't upload any type of file nor mp4, gif, webm. Well ¯_(ツ)_/¯ for anyone who wants to try <Space> selects/deselects and pressing <Enter> on item while having in selection others, will install that item too.

darukutsu
darukutsu commented Mar 22, 2025
View reviewed changes
internal/pacseek/data.go
}

var pkglist []PkgStatus
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know go that well, I need to access this variable in 2 different files. I think defining it on top of setup.go should work too, but not sure if proper place for it. Also I'm passing it as copy slice not as pointer, then functions return new modified slice ,not sure if it's deal-braker.

@darukutsu darukutsu mentioned this pull request Apr 1, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] Select several packages
1 participant
@darukutsu