Simplify setup, add failing test, code coverage

[briancavalier]

Just thinking out loud here, and all of this is totally up for discussion.

Two of the biggest changes are:

1. switching to the name index.js to avoid the two mv commands. I'm not a huge fan of that name, but I also don't mind it. In this case, it makes life a bit easier. Thoughts?
2. making the test fail by default 😈. My thinking is that this forces someone to at least look at it, although, maybe it's too heavy handed?

[briancavalier]

Added code coverage with isparta. I'd rather use nyc, but it's coverage reports are broken. Maybe something like this would work, or we can wait for a fix and then switch.

[TylorS]

I don't know anything about code coverage, so I think that if this works for now I'm all for it.

[briancavalier]

Yeah, agreed. I say we just go with isparta and keep an eye on nyc.

Any thoughts on index.js and making the test fail by default?

cc @davidchase

[davidchase]

The index.js seems like good convention... as it does make life easier we use that in our current project...

I think we can use what works for test coverage... i think nyc was done initially because of ava... could be wrong

what is the idea for failing the test by default? is that for consumer to be a good citizen before submitting their packages?

[briancavalier]

I think we can use what works for test coverage

👍

is that for consumer to be a good citizen before submitting their packages?

Yeah, although now I think it's too heavy-handed :) Since we'll have test coverage, that's probably enough.

[TylorS]

index.js seems okay. That's what I was going to do originally, but it seemed to be of convention to name the 'main' file the same as the package name. e.g. @most/dom-event -> dom-event.js

Regarding the tests, I think having them fail is okay, if someone really doesn't want to write tests they could delete them.

[briancavalier]

Ok, I tweaked a few things. Let me know what you think.

1. Test passes by default now. I say we just pick pass or fail and run with it. I picked pass.
2. Test uses function exported from index.js
3. Removed reference to @most/core, since it doesn't exist (yet)

[TylorS]

I think it all looks good

[briancavalier]

Any other thoughts, @davidchase? Good to merge?

[davidchase]

yeah i think its good to merge... if you guys dont mind when i have sometime i still would like to tackle the ava and co setup just to see what i can come up with and see if any of that is viable both for curiosity and potential use in the project

[TylorS]

I have no issues with at least trying to move to ava in the future. It's always worth trying potentially better things. 👍

Merge and transfer to the mostjs org?

[briancavalier]

i still would like to tackle the ava and co setup

Sure 👍

Merge and transfer to the mostjs org?

👌 go for it!

[TylorS]

Merged and transferred

[briancavalier]

💥