-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Don't exclude arm64 build for the simulator #1498
Conversation
I'll be prototyping the "Better Builds" proposal next week, this may help me with packaging the iOS stuff as I'm sure that app-services will face a similar issue with this (as will Nimbus when we have iOS for it). |
|
8fd6aa3
to
82aa742
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: reminder to file a bug to change this once the feature has made it to release in rustc.
That might or might not happen anytime soon unfortunately (we'll see, I'm in the rust zulip to see how we can push it forward) |
This currently requires a local build of rustc with rust-lang/rust#81966 to enable the target (and also LLVM 12, LLVM 11 untested). Thus we can't really land that before that becomes stable.
I think it would also require direct consumers to switch over to xcframeworks.
It's untested in app-services, I guess it could work for Intel builds there, but this would need to be tested.
No need for a formal review or test yet.