-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Run minification directly during Webpack building #17686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run minification directly during Webpack building #17686
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/1620c856898faa8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1620c856898faa8/output.txt Total script time: 1.20 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/142b360697ab010/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b3ad81fc1fafcd0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/142b360697ab010/output.txt Total script time: 24.78 mins
Image differences available at: http://54.241.84.105:8877/142b360697ab010/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b3ad81fc1fafcd0/output.txt Total script time: 38.74 mins
Image differences available at: http://54.193.163.58:8877/b3ad81fc1fafcd0/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice simplification; thanks!
r=me with the comment below addressed and the merge conflict fixed.
Rather than first building the library and then use Terser "manually" to minify the files, we can utilize a Webpack plugin to combine these steps which helps to simplify the gulpfile.
758f256
to
091e861
Compare
Rather than first building the library and then use Terser "manually" to minify the files, we can utilize a Webpack plugin to combine these steps which helps to simplify the gulpfile.