-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add margin to separate radio buttons and checkboxes from their labels #19765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Have you actually run Note that this looks effectively like a duplicate of PR #17948, which caused lots of regressions and thus couldn't be merged. |
When I ran When I ran
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7361414c81b3c63/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e828d74d270b821/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7361414c81b3c63/output.txt Total script time: 17.97 mins
Image differences available at: http://54.241.84.105:8877/7361414c81b3c63/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e828d74d270b821/output.txt Total script time: 39.38 mins
Image differences available at: http://54.193.163.58:8877/e828d74d270b821/reftest-analyzer.html#web=eq.log |
@Snuffleupagus I've been poking around in |
@calixteman bumping this - would appreciate some guidance here! |
@gpanakkal did you analyze why, for example the rendering in |
Yes, I analyzed all the reftest failures by hand. Adding space should occur during layout calculations so that adequate room is allocated for the label, but the original approach of adding margin via CSS meant that new margin was added after layout was calculated, so text was cut off in 7 failing pages ( It appears that Acrobat adds up to 2.5px between check buttons and their labels, or less based on how much space is available for the label.
Thanks, this is quite helpful! Looks like Acrobat prunes whitespace around label text; see the second-to-last "Yes" label on page 5 of
I just wanted some general guidance to make sure I wasn't heading in the wrong direction altogether, since I'm not familiar with the codebase. 2.5px margin is just a placeholder solution in the meantime. From my current understanding, a proper fix requires both:
I'm on the fence about whether or not I should continue working on this bug. Let me know if these changes sound correct and reasonably easy to implement.
Will do! |
This PR addresses bug 1716806 by adding a 4px margin to the right of checkboxes and radio buttons for
.xfaRight
elements, or to the left for.xfaLeft
elements.