-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cryptographic backend isolation tests #109
Merged
mpdavis
merged 7 commits into
mpdavis:backend-explicit-tests
from
mattsb42-aws:explicit-dependencies
Nov 9, 2018
Merged
Cryptographic backend isolation tests #109
mpdavis
merged 7 commits into
mpdavis:backend-explicit-tests
from
mattsb42-aws:explicit-dependencies
Nov 9, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Fix typo in error message upon key deserialization
NOTE: This identified a few bugs with the python-rsa and pyca/cryptography backends. Those will fail for now.
c8aa469
to
4d7b598
Compare
Codecov Report
@@ Coverage Diff @@
## backend-explicit-tests #109 +/- ##
==========================================================
- Coverage 94.61% 65.2% -29.42%
==========================================================
Files 13 13
Lines 1003 1003
==========================================================
- Hits 949 654 -295
- Misses 54 349 +295
Continue to review full report at Codecov.
|
lgtm |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #108, this is the initial step in cryptographic backend isolation. This change adjusts the most test fixtures to use "whatever backend is available" and adds tox test environments that isolate the cryptographic backends to verify that all tests actually pass for all backends.
NOTE: As discussed in #108, some tests do fail as a result of this. Fixing that is the next step.