Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep backend-explicit-tests for merge #128

Merged
merged 6 commits into from
Apr 7, 2019

Conversation

mattsb42-aws
Copy link
Contributor

@mattsb42-aws mattsb42-aws commented Apr 7, 2019

Given the relative number of changes, I figured it would be better to merge master into backend-explicit-tests first before merging backend-explicit-tests into master. That way the changes are smaller and more reviewable.

Next step from here will simply be merging backend-explicit-tests into master.

@mattsb42-aws mattsb42-aws changed the title Merge in master Prep backend-explicit-tests for merge Apr 7, 2019
@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #128 into backend-explicit-tests will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           backend-explicit-tests     #128      +/-   ##
==========================================================
- Coverage                   96.53%   96.52%   -0.01%     
==========================================================
  Files                          14       14              
  Lines                        1068     1065       -3     
==========================================================
- Hits                         1031     1028       -3     
  Misses                         37       37
Impacted Files Coverage Δ
jose/jwt.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5d551...3d7f084. Read the comment docs.

@zejn
Copy link
Collaborator

zejn commented Apr 7, 2019

Looks good to me.

@zejn zejn merged commit 64cb29f into mpdavis:backend-explicit-tests Apr 7, 2019
@mattsb42-aws mattsb42-aws deleted the merge-in-master branch April 7, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants