Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix block that can happen when type is not resolved #45358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JCQuintas
Copy link
Member

The type descriptor can be undefined in some instances, when this script fails to detect the correct types. This would cause the script to crash and block progress.

@JCQuintas JCQuintas added bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product labels Feb 19, 2025
@JCQuintas JCQuintas requested a review from a team February 19, 2025 14:20
@JCQuintas JCQuintas self-assigned this Feb 19, 2025
@mui-bot
Copy link

mui-bot commented Feb 19, 2025

Netlify deploy preview

https://deploy-preview-45358--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e2f7573

@alexfauquette
Copy link
Member

Do you have an example where this issue occures?

@JCQuintas
Copy link
Member Author

@alexfauquette It happened on mui/mui-x#16640 though I've disabled the api generation on scripts/buildApiDocs/chartsSettings/index.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants