[wip] Improve RTL switch on docs #45360
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45360--material-ui.netlify.app/ Bundle size report |
docs/pages/_app.js
Outdated
| <AppWrapper emotionCache={emotionCache} pageProps={pageProps}> | ||
| {getLayout(<Component {...pageProps} />)} | ||
| </AppWrapper> | ||
| <CacheProvider value={emotionCache}> |
There was a problem hiding this comment.
This reminds me of another problem. Why do we expose @mui/material-nextjs to users if we don't fully use it on the docs (we only use documentGetInitialProps from it, but not AppCacheProvider)? We should move to dogfood it?
(Arguably, it's a @mui/system-nexjs module but that's another problem)
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44534
The main change is reverting #28495I am bringing back again this change. There is a big difference between components pages vs other pages that needs to be investigated. I had a false positive when doing this change because I was not testing the components pages.
Preview: https://deploy-preview-45360--material-ui.netlify.app/