[material-ui][Slider] Fix spacings in .md files #45388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sai6855
commented
Feb 24, 2025
•
sai6855
commented
- I have followed (at least) the PR section of the contributing guide.
sai6855
added
component: slider
Netlify deploy previewBundle size report |
sai6855
commented
Feb 24, 2025
| @@ -2011,35 +2011,35 @@ Here's how to migrate: | |||
| MuiSlider: { | |||
| styleOverrides: { | |||
| root: { | |||
| - [`&.${sliderClasses.thumbSizeSmall}`]: { | |||
There was a problem hiding this comment.
thumbSizeSmall class is applied to thumb, not root. hence, a space has been added here.
docs for same -> https://mui.com/material-ui/api/slider/#slider-classes-MuiSlider-thumbSizeSmall
|
Cherry-pick PRs will be created targeting branches: v6.x |
DiegoAndai
reviewed
Feb 24, 2025
Comment on lines
+2034
to
+2035
| - [`& .${sliderClasses.thumbColorInfo}`]: { | ||
| + [`& .${sliderClasses.thumb}.${sliderClasses.colorInfo}`]: { |
There was a problem hiding this comment.
Hey @sai6855, I just noticed after merging that this is the other way around. It should be
[`&.${sliderClasses.colorInfo} > .${sliderClasses.thumb}`]: {
May I ask you to open a PR to update it?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.