-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix publish dry run script #45421
base: master
Are you sure you want to change the base?
Conversation
@@ -16,7 +16,7 @@ | |||
"release:build": "lerna run --concurrency 8 --no-private build --skip-nx-cache", | |||
"release:changelog": "node scripts/releaseChangelog.mjs", | |||
"release:publish": "pnpm publish --recursive --tag next", | |||
"release:publish:dry-run": "pnpm publish --recursive --tag next --registry=\"http://localhost:4873/\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we used to use this? https://verdaccio.org/docs/configuration/#listen-port
With pnpm we can just use the built-in --dry-run
: https://pnpm.io/9.x/cli/publish#--dry-run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we've used verdaccio before for testing publishes. It allowed us to also test an install from registry.
Netlify deploy previewhttps://deploy-preview-45421--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I feel like the pnpm dryrun option is doing something different than what this script intends to do
The
pnpm release:publish:dry-run
script doesn't work