Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix publish dry run script #45421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mj12albert
Copy link
Member

The pnpm release:publish:dry-run script doesn't work

@mj12albert mj12albert added the core Infrastructure work going on behind the scenes label Feb 26, 2025
@@ -16,7 +16,7 @@
"release:build": "lerna run --concurrency 8 --no-private build --skip-nx-cache",
"release:changelog": "node scripts/releaseChangelog.mjs",
"release:publish": "pnpm publish --recursive --tag next",
"release:publish:dry-run": "pnpm publish --recursive --tag next --registry=\"http://localhost:4873/\"",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we used to use this? https://verdaccio.org/docs/configuration/#listen-port

With pnpm we can just use the built-in --dry-run: https://pnpm.io/9.x/cli/publish#--dry-run

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we've used verdaccio before for testing publishes. It allowed us to also test an install from registry.

@mui-bot
Copy link

mui-bot commented Feb 26, 2025

Netlify deploy preview

https://deploy-preview-45421--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b6e85ae

@mj12albert mj12albert marked this pull request as ready for review February 28, 2025 07:34
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I feel like the pnpm dryrun option is doing something different than what this script intends to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants