Fix moduleResolution:node for icons #45444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
regression
Netlify deploy previewhttps://deploy-preview-45444--material-ui.netlify.app/ Bundle size report |
DiegoAndai
reviewed
Mar 3, 2025
| @@ -37,7 +37,8 @@ | |||
| "release": "pnpm build && pnpm publish", | |||
| "test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-material/**/*.test.?(c|m)[jt]s?(x)'", | |||
| "typescript": "tsc -p tsconfig.json", | |||
| "typescript:module-augmentation": "node scripts/testModuleAugmentation.js" | |||
| "typescript:module-augmentation": "node scripts/testModuleAugmentation.js", | |||
| "attw": "attw --pack ./build --exclude-entrypoints esm modern --include-entrypoints Button styles" | |||
There was a problem hiding this comment.
Should we add the attw check for all packages?
Why exclude esm and modern?
There was a problem hiding this comment.
I added a few key packages that most people would use, and the icons that have a more exotic setup. didn't want to add too much to CI for packages that most people won't import and that won't regress on their own anyway as it all uses the same automation. We can remove the exclusions after arethetypeswrong/arethetypeswrong.github.io#242 is fixed.
DiegoAndai
approved these changes
Mar 3, 2025
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "moduleResolution: node" for the icons package as per #43938 (comment)
We moved to a single declaration file for all icons but this breaks under classic module resolution. This can be fixed using
typesVersions.I'm also adding
attwchecks in CI to avoid this from regression again. (Opening arethetypeswrong/arethetypeswrong.github.io#242 along the way)