-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update ARM Toolchain and libopencm #373
base: master
Are you sure you want to change the base?
Conversation
rpls
commented
Jan 9, 2025
•
edited
Loading
edited
- PR changes testvectors
- Tests pass in qemu
- Testvectors pass in qemu
- Tests pass on Nucleo-L4R5ZI
- Testvectors pass on Nucleo-L4R5ZI
- Updated Benchmarks
- Updated Skiplist entries
Well, sphincs doesn't build anymore, and |
Wow. build failures can happen, but testvector failures are rather worrying. |
So for sphincs we need a fix in PQClean/PQClean#582, for |
98d0c95
to
a959691
Compare
@rpls - the fix for SPHINCS+ has been merged upstream in PQClean/PQClean#584. Could you do another rounds of tests and benchmarks, please? |
So far, a couple of weird failures. Some of the mirith variants hang indefinitely. |
I know why MAYO fails: this version of the code does not handle sm=m correctly. We have fixed that in round 2. (Note that the speed.c was changed only recently to include checking of the verification result). I will update MAYO soon™️. Can you figure out if the other failures are also caused by this (simply using two buffers should be sufficient)? If so, we should inform the submitters to fix their code. |