Migration from glide to dep #319
Conversation
|
|
||
| [[prune.project]] | ||
| name = "github.com/ethereum/go-ethereum" | ||
| unused-packages = false |
| go-tests = true | ||
| unused-packages = true | ||
|
|
||
| [[prune.project]] |
There was a problem hiding this comment.
Global unused-packages is a little evil I agree - so no we can specificy this flag per dependency? It would be a bit tricky to track if we need this flag for specific depedency or not - especially if it has transitive dependencies. and this flag is very important if package uses cgo - as any .c .h files will be pruned if this flag is true. That's a bit of consideration
There was a problem hiding this comment.
Yeah, now it can be used for per project configuration.
Regarding cases when we need to save unused-packages, I think, we should use it only when something does not work without it. It keeps a vendor directory much smaller.
There was a problem hiding this comment.
Alright. That's a new feature I guess? As long as I remember it was global flag only
There was a problem hiding this comment.
Not sure when it was introduced.
Found the only bug when it was broken: golang/dep#1561 )
soffokl
force-pushed
the
experiment/glide-to-dep
branch
from
76730d7 to
640b213
Compare
soffokl
changed the title
| @@ -38,8 +34,8 @@ jobs: | |||
| - stage: dep-cache | |||
| name: "Vendor update" | |||
| script: | |||
| - source bin/travis_scripts/ensure_glide.sh $BUILD_TOOLS_PATH "v0.13.1" | |||
| - glide "-home" $GLIDE_HOME install | |||
| - curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh | |||
There was a problem hiding this comment.
It is strongly recommended that you use a released version.
And go get requires to get sources and build it, so it probably a bit slower than download just binary.
| @@ -6,7 +6,7 @@ | |||
| * **Step 1.** Get project dependencies | |||
| ```bash | |||
| brew install go | |||
| brew install glide | |||
| brew install dep | |||
There was a problem hiding this comment.
We collect our development dependencies into node-builder image here bin/builder_docker/Dockerfile
soffokl
force-pushed
the
experiment/glide-to-dep
branch
2 times, most recently
from
32065b7 to
3a0251f
Compare
soffokl
force-pushed
the
experiment/glide-to-dep
branch
from
3a0251f to
c031903
Compare
No description provided.