feat(editor): Popping logs out into a new window #13788
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Changes in this file makes it possible to listen to the right window object when the resizer is used in a PiP window
There was a problem hiding this comment.
Changes in this file are needed to show tooltips properly in a PiP window.
I'm using provide/inject instead of props so that I don't have to modify individual usages of the tooltip component.
There was a problem hiding this comment.
Agreed with product to remove the confirmation dialog of clearing the chat history. In the future we'll need to make the dialog work in PiP window as well. Right now it always shows in the main window even when the user is interacting in PiP window.
| isSupported, | ||
| // When the `copy()` method is invoked from inside of the document picture-in-picture (PiP) window, it throws the error "Document is not focused". | ||
| // Therefore, we disable copying features in the PiP window for now. | ||
| isSupported: computed(() => isSupported && !isInPiPWindow.value), |
There was a problem hiding this comment.
I didn't find any usages of isSupported in the codebase, so it should be safe to change boolean to ComputedRef<boolean> here.
Summary
This PR implements the feature to pop out the chat and logs pane at the bottom of canvas.
The feature is built on top of Google Chrome's experimental
documentPictureInPictureAPI. For other browsers and insecure context which disallows the usage of this API, the button to pop out the pane is hidden.Screencast.from.2025-03-12.09-29-16.webm
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/SUG-20/popping-logs-out-into-a-new-window
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)