Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow custom scopes for Entra credential #13796

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Mar 10, 2025

Summary

This updates the Entra credential to allow custom scopes, Due to how the scopes are loading I had to make a second input field as just changing the display option for the normal scopes field didn't allow the scopes to be changed.

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2399/digital-boss-microsoft-entra-id#comment-23c193b5

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@pemontto
Copy link
Contributor

Please do this for all OAuth nodes! At least for now this would also be useful for the Teams node which currently requests Group.ReadWrite.All - packages/nodes-base/credentials/MicrosoftTeamsOAuth2Api.credentials.ts

@dana-gill dana-gill self-requested a review March 11, 2025 09:04
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Mar 11, 2025

n8n    Run #9690

Run Properties:  status check passed Passed #9690  •  git commit 412482b821: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project n8n
Branch Review node-2399-digital-boss-microsoft-entra-id
Run status status check passed Passed #9690
Run duration 04m 42s
Commit git commit 412482b821: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Committer Jonathan Bennetts
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 441
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants