Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Merge Node): Better pairedItem mapping in combineBySql operation if SELECT query #13849

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

michael-radency
Copy link
Contributor

Summary

Better pairedItem mapping in combineBySql operation if SELECT query
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1606/paired-item-in-merge-sql-operation-merge-node

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team node/issue Issue with a node labels Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 83.07692% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s-base/nodes/Merge/v3/actions/mode/combineBySql.ts 74.41% 9 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@dana-gill dana-gill requested a review from ShireenMissi March 12, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/issue Issue with a node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants