Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Address folders feature feedback (no-changelog) #13859

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Mar 12, 2025

Summary

Addressing the feedback we got from internal folders testing.
Main updates:

  • Fixing issue with empty state flashing when changing folders
  • Adding read-only state for Folder card
  • Disabling actions based on user permissions (scope)
  • Hiding Create Folder action from the project header on other pages and tabs
  • Showing all workflows in overview page (previously it only showed ones that are not in folders)
  • Folder card responsiveness improvements
  • Handling long folder names in card & breadcrumbs
  • Updating folder icon & other design feedback

Related Linear tickets, Github issues, and Community forum posts

Closes ADO-3285

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Mar 12, 2025
@MiloradFilipovic MiloradFilipovic marked this pull request as draft March 12, 2025 10:29
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ges/frontend/editor-ui/src/views/WorkflowsView.vue 88.37% 5 Missing ⚠️
...ditor-ui/src/components/Projects/ProjectHeader.vue 20.00% 4 Missing ⚠️
...or-ui/src/components/Folders/DeleteFolderModal.vue 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@MiloradFilipovic MiloradFilipovic marked this pull request as ready for review March 12, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant