Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUMULUS-3147] - updating node version to 16.19 #3228

Merged
merged 68 commits into from
Mar 6, 2023
Merged

[CUMULUS-3147] - updating node version to 16.19 #3228

merged 68 commits into from
Mar 6, 2023

Conversation

Nnaga1
Copy link
Contributor

@Nnaga1 Nnaga1 commented Jan 11, 2023

Summary: Summary of changes

Addresses CUMULUS-XX: Develop amazing new feature

Changes

  • Detailed list or prose of changes
  • ...

PR Checklist

  • [ x] Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

@Nnaga1 Nnaga1 changed the title [CUMULUS-3147] - updating node version to 18 [CUMULUS-3147] - updating node version to 16.17 Jan 18, 2023
@Nnaga1
Copy link
Contributor Author

Nnaga1 commented Jan 24, 2023

This is the error they are experiencing for the syncGranule task: https://eosdis.slack.com/archives/C76M787MZ/p1671561820716219 , essentially : syncGranule ECS task log: node[1]: ../src/node_http_parser_impl.h:487:static void node::{anonymous}::Parser::Execute(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `parser->current_buffer_.IsEmpty()' failed.

This is the error for node-18 upgrade, resulting in failure in deploy-dev-stack step: (nnaga-ci-tf-CustomBootstrap) returned error: ({"errorType":"Runtime.ImportModuleError","errorMessage":"Error: Cannot find module 'aws-sdk'\nRequire stack:\n- /var/task/index.js\n- /var/runtime/index.mjs","trace":["Runtime.ImportModuleError: Error: Cannot find module 'aws-sdk'","Require stack:","- /var/task/index.js","- /var/runtime/index.mjs"," at _loadUserApp (file:///var/runtime/index.mjs:1000:17)"," at Object.UserFunction.js.module.exports.load (file:///var/runtime/index.mjs:1035:********)"," at start (file:///var/runtime/index.mjs:1200:23)"," at file:///var/runtime/index.mjs:1206:1"]}) It seems to be a known error : aws/aws-cdk#22976, but it isn't quite clear to me what the workaround is.

Copy link
Contributor

@jennyhliu jennyhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We probably want to use the latest node 16
  2. Update https://github.com/nasa/cumulus/pull/3228/files#diff-16668ffceabc29f1ac6035001afb94920ff2c385359e558fbffa51b94a8a0e27R6
    We need to build image, publish and use it for our example stack build.
    https://github.com/nasa/cumulus/tree/master/packages/api/ecs/async-operation
  3. Publish a node 16 image for ci testing.
  4. Add test to verify the update solve the current_buffer_.IsEmpty() issue daac has.

@Nnaga1
Copy link
Contributor Author

Nnaga1 commented Jan 24, 2023

Is there documentation on how to do this? Publish a node 16 image for ci testing.

@jennyhliu
Copy link
Contributor

jennyhliu commented Jan 25, 2023

Is there documentation on how to do this? Publish a node 16 image for ci testing.

Nate and Jonathan know how to.

@Nnaga1 Nnaga1 changed the title [CUMULUS-3147] - updating node version to 16.17 [CUMULUS-3147] - updating node version to 16.19 Jan 25, 2023
Copy link
Contributor

@jennyhliu jennyhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@Nnaga1 Nnaga1 merged commit e73ad8e into master Mar 6, 2023
@Nnaga1 Nnaga1 deleted the CUMULUS-3147 branch March 6, 2023 20:05
@jennyhliu jennyhliu mentioned this pull request Mar 10, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants