Implement Type Alias codegen #645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocchino
reviewed
Mar 6, 2025
bocchino
reviewed
Mar 6, 2025
| } | ||
|
|
||
| private def getHppMembers: List[CppDoc.Member] = { | ||
| List( |
There was a problem hiding this comment.
It's better to use List.concat here instead of List(...).flatten.
bocchino
reviewed
Mar 6, 2025
|
|
||
| private def getHOpenCPPGuard: CppDoc.Member = { | ||
| linesMember(addBlankPrefix(lines( | ||
| """|#ifdef __cplusplus |
There was a problem hiding this comment.
Can we omit the #ifdef __cplusplus here? This is a C-only header, right? The extern "C" should go in the C++ header.
bocchino
reviewed
Mar 6, 2025
|
|
||
| #include "Fw/Types/BasicTypes.h" | ||
|
|
||
| #ifdef __cplusplus |
There was a problem hiding this comment.
Let's omit #ifdef __cplusplus extern "C" here and add extern "C" in the hpp file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #622