Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CPP to build with latest GHC (9.10) #111

Merged
merged 2 commits into from
May 10, 2024
Merged

Add CPP to build with latest GHC (9.10) #111

merged 2 commits into from
May 10, 2024

Conversation

vmchale
Copy link
Contributor

@vmchale vmchale commented Mar 14, 2024

As of GHC 9.10, sortOn for nonempty lists is part of base.

@josephcsible
Copy link
Contributor

Since the change in question was to the base library and not the compiler itself, can you use #if MIN_VERSION_base(4,20,0) instead?

@ndmitchell ndmitchell merged commit 1836347 into ndmitchell:master May 10, 2024
ndmitchell added a commit that referenced this pull request May 10, 2024
@ndmitchell
#111, update yhe changelog
501f35f 
Summary:

Test Plan:
@ndmitchell
Copy link
Owner

Thanks! Released as https://hackage.haskell.org/package/extra-1.7.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephcsible josephcsible josephcsible left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmchale @josephcsible @ndmitchell