Change nomination #146
Change nomination #146
Conversation
|
Your Render PR Server URL is https://near-explorer-frontend-pr-146.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
A deploy for your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com just failed. View details on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
A deploy for your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com just failed. View details on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
this one fix the bug for fs in next and nearlib |
|
Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
|
|
Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
frontend/src/components/transactions/__tests__/__snapshots__/ActionMessage.test.tsx.snap
Outdated
Show resolved
Hide resolved
| webpack: (config, { isServer }) => { | ||
| // Fixes npm packages that depend on `fs` module | ||
| if (!isServer) { | ||
| config.node = { | ||
| fs: "empty" | ||
| }; | ||
| } |
There was a problem hiding this comment.
Is this something wrong with nearlib? Do we have an issue there? Can we fix it there? /cc @janedegtiareva
There was a problem hiding this comment.
vercel/next.js#7755 the issue and method is here.
There was a problem hiding this comment.
Vlad and I talked about this and this definitely can fix in the nearlib, nearlib does not fit browser configuration and webpack maybe a good method to do with that
There was a problem hiding this comment.
Let's create a tracking issue on nearlib and put a link to the issue in a comment here.
|
find out the test is okay just because testnet is down yesterday. If nearlib is not changing anymore, this version for explorer is ready to go. |
I created a separate issue to encapsulate this #152 (and put it as highest priority), as we're proceeding with yoctoNEAR rollout currently. |
|
Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
|
Your Render PR Server at https://near-explorer-frontend-pr-146.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bnp8pdt8rbk6vh54d4jg. |
fix the issue #134 but we should still wait ubtil nearcore and nearlib is okay to update