runtime: parallel transaction verification #12983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
requested changes
Feb 24, 2025
miloserdow
commented
Mar 3, 2025
miloserdow
force-pushed
the
miloserdow/threaded-verify-2
branch
3 times, most recently
from
9f1cfe5 to
7c9782a
Compare
miloserdow
changed the title
miloserdow
force-pushed
the
miloserdow/threaded-verify-2
branch
from
f814152 to
baa9cff
Compare
nagisa
reviewed
Mar 10, 2025
Introduces ephemeral structures used to accumulate changes for parallel transaction verification in runtime
nagisa
approved these changes
Mar 17, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12983 +/- ##
===========================================
+ Coverage 1.74% 70.02% +68.28%
===========================================
Files 671 866 +195
Lines 121044 177230 +56186
Branches 121044 177230 +56186
===========================================
+ Hits 2113 124108 +121995
+ Misses 118827 47922 -70905
- Partials 104 5200 +5096
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akhi3030
reviewed
Mar 17, 2025
akhi3030
reviewed
Mar 17, 2025
akhi3030
reviewed
Mar 17, 2025
akhi3030
reviewed
Mar 17, 2025
akhi3030
reviewed
Mar 18, 2025
miloserdow
added a commit
that referenced
this pull request
Mar 19, 2025
This reverts commit 0d1eb42. The reason for revert is that change brakes archival nodes.
miloserdow
added a commit
to miloserdow/nearcore
that referenced
this pull request
Mar 20, 2025
During the development of parallel transaction processing (near#12983), we encountered a bug when multiple transactions from the same account using different keys were included in a single chunk. In this scenario, the account balance was calculated incorrectly because these transactions were processed in parallel. This PR adds two new tests: one to verify the correct ordering of transaction outcomes and another to validate transactions signed with different keys from the same account.
miloserdow
added a commit
to miloserdow/nearcore
that referenced
this pull request
Mar 20, 2025
During the development of parallel transaction processing (near#12983), we encountered a bug when multiple transactions from the same account using different keys were included in a single chunk. In this scenario, the account balance was calculated incorrectly because these transactions were processed in parallel. This PR adds two new tests: one to verify the correct ordering of transaction outcomes and another to validate transactions signed with different keys from the same account.
miloserdow
added a commit
to miloserdow/nearcore
that referenced
this pull request
Mar 25, 2025
During the development of parallel transaction processing (near#12983), we encountered a bug when multiple transactions from the same account using different keys were included in a single chunk. In this scenario, the account balance was calculated incorrectly because these transactions were processed in parallel. This PR adds two new tests: one to verify the correct ordering of transaction outcomes and another to validate transactions signed with different keys from the same account.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
During the development of parallel transaction processing (#12983), we encountered a bug when multiple transactions from the same account using different keys were included in a single chunk. In this scenario, the account balance was calculated incorrectly because these transactions were processed in parallel. This PR adds two new tests: one to verify the correct ordering of transaction outcomes and another to validate transactions signed with different keys from the same account.
wacban
pushed a commit
that referenced
this pull request
Mar 25, 2025
During the development of parallel transaction processing (#12983), we encountered a bug when multiple transactions from the same account using different keys were included in a single chunk. In this scenario, the account balance was calculated incorrectly because these transactions were processed in parallel. This PR adds two new tests: one to verify the correct ordering of transaction outcomes and another to validate transactions signed with different keys from the same account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we group transactions by
(account, access_key)sorted by nonce and verify those groups in parallel. Then we apply state updates and process receipts sequentially.