refactor: tx_cost does not need to be told if sender_is_receiver
#13020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhi3030
commented
Feb 28, 2025
| @@ -25,6 +25,7 @@ pub(crate) async fn convert_transactions_sir_into_local_receipts( | |||
| let local_receipts: Vec<views::ReceiptView> = | |||
| txs.into_iter() | |||
| .map(|tx| { | |||
| assert_eq!(tx.transaction.signer_id, tx.transaction.receiver_id); | |||
There was a problem hiding this comment.
note to reviewer: I could not validate that this condition should always hold. As the previous code was always setting sender_is_receiver to true, I inserted this assertion here.
It might also not be a bad assertion given the name of the function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13020 +/- ##
==========================================
- Coverage 69.91% 69.90% -0.01%
==========================================
Files 859 859
Lines 176206 176306 +100
Branches 176206 176306 +100
==========================================
+ Hits 123189 123255 +66
- Misses 47858 47881 +23
- Partials 5159 5170 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shreyan-gupta
pushed a commit
to shreyan-gupta/nearcore
that referenced
this pull request
Mar 28, 2025
shreyan-gupta
pushed a commit
to shreyan-gupta/nearcore
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.