Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: expose an internal cloning to the callers #13112

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

akhi3030
Copy link
Collaborator

Helps address this issue: #13075 (comment).

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.00%. Comparing base (10ebcc4) to head (6a732c1).

Files with missing lines Patch % Lines
...chain/src/stateless_validation/chunk_validation.rs 85.71% 1 Missing ⚠️
...client/src/stateless_validation/shadow_validate.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13112      +/-   ##
==========================================
+ Coverage   69.93%   70.00%   +0.06%     
==========================================
  Files         863      863              
  Lines      176727   176728       +1     
  Branches   176727   176728       +1     
==========================================
+ Hits       123593   123713     +120     
+ Misses      47965    47838     -127     
- Partials     5169     5177       +8     
Flag Coverage Δ
backward-compatibility 0.36% <0.00%> (-0.01%) ⬇️
db-migration 0.36% <0.00%> (-0.01%) ⬇️
genesis-check 1.43% <0.00%> (?)
linux 69.83% <85.71%> (+0.07%) ⬆️
linux-nightly 69.54% <85.71%> (-0.03%) ⬇️
pytests 1.74% <0.00%> (+1.37%) ⬆️
sanity-checks 1.55% <0.00%> (?)
unittests 69.83% <85.71%> (+<0.01%) ⬆️
upgradability 0.36% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akhi3030 akhi3030 added this pull request to the merge queue Mar 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 12, 2025
@akhi3030 akhi3030 added this pull request to the merge queue Mar 12, 2025
Merged via the queue into near:master with commit be4cd5e Mar 12, 2025
21 of 24 checks passed
@akhi3030 akhi3030 deleted the expose-clone branch March 12, 2025 20:05
shreyan-gupta pushed a commit to shreyan-gupta/nearcore that referenced this pull request Mar 28, 2025
shreyan-gupta pushed a commit to shreyan-gupta/nearcore that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants