refactor:process_transactions does not drop validated txs
#13136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhi3030
force-pushed
the
fix-validte-apply-state-update
branch
from
408cc8a to
6a5dbf2
Compare
akhi3030
changed the title
process_transactions does not drop validated txsprocess_transactions does not drop validated txs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13136 +/- ##
==========================================
+ Coverage 70.01% 70.03% +0.02%
==========================================
Files 865 865
Lines 176910 176939 +29
Branches 176910 176939 +29
==========================================
+ Hits 123865 123926 +61
+ Misses 47861 47840 -21
+ Partials 5184 5173 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akhi3030
force-pushed
the
fix-validte-apply-state-update
branch
from
6a5dbf2 to
4c2d4a6
Compare
akhi3030
changed the title
process_transactions does not drop validated txsprocess_transactions does not drop validated txs
akhi3030
changed the title
process_transactions does not drop validated txsprocess_transactions does not drop validated txs
|
I'm gonna punt on this until @miloserdow's changes land. |
|
closing in favour of #13122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the work being tracked in #13140
This PR combined with #13122 allows us to remove an expensive unnecessary cloning of signed transactions in https://github.com/near/nearcore/blob/master/runtime/runtime/src/lib.rs#L1716.
Reviewer: if you do not like the intermediate state of this PR, I am happy to combine it with #13122 but I thought that will be too ugly to review.