Fix for issue #719 - Touchable: right-click triggers onPress #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For components based on Touchable, in the conditions: - Secondary mouse click alone - Secondary mouse click while primary is active - Dragging secondary mouse click on touchable area - Dragging secondary mouse click from touchable area to outside The following events are no longer triggered: - onPress - onLongPress - onPressIn - onPressOut
|
Thanks. I've made a simpler fix to the responder event system that I think fixes this issue, and prevents right-clicks from triggering any events in the responder system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For components based on Touchable, in the conditions:
The following events are no longer triggered: